Add logout button to docs page - #25
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcruzeneil2
marked this pull request as ready for review
August 3, 2026 19:38
rgarcia
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
/docstesting
npx tsc --noEmitnpm testnpm run buildnpm run spec:checkNote
Medium Risk
Touches session revocation and cookie handling, but uses existing origin CSRF checks and is covered by focused route and UI tests.
Overview
Signed-in users on
/docsget a log out control next to the account line (POST form to/logout), with light flex styling on the session header row.POST /logoutenforcesoriginOkCSRF checks, revokes the activesessionsrow when a validjh_sesstoken is present, always clears the session cookie via newclearSessionCookieHeader(), and redirects to/login. Vitest covers the route (revoke, stale cookie, cross-site 403) and the docs HTML includes the logout form.Reviewed by Cursor Bugbot for commit 5438dfd. Bugbot is set up for automated code reviews on this repo. Configure here.